fix(defaultModel): prevent star button injection into non-model menus - #481
Merged
Conversation
The fallback selector `.mat-mdc-menu-panel[role="menu"]` was too broad, causing default-model star buttons to appear in the settings dropdown and theme picker submenu. Fix with two layers of defense: 1. Exclude `.desktop-settings-menu` from the fallback CSS selector 2. Add isModelMenu guard requiring `.title-and-description`, `.mode-title`, or `[data-mode-id]` before injecting — markers absent from non-model menus Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mat-mdc-menu-panel[role="menu"]was too broad, causing default-model star buttons (gv-default-star-btn) to appear in the settings dropdown and theme picker submenu:not(.desktop-settings-menu)to the fallback CSS selector to exclude the settings menuisModelMenuguard ininjectStarButtons()requiring.title-and-description,.mode-title, or[data-mode-id]— markers absent from non-model menus like the theme picker (which usesmenuitemradiobut lacks model-specific DOM structure)Test plan
desktop-settings-menu) does not receive star buttonsmenuitemradiowithout model markers) does not receive star buttons🤖 Generated with Claude Code