feat(api): add NANGO_ADMIN_PROD_ENV env var #3828
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
Apr 1, 2025
| @@ -30,7 +32,7 @@ class ConnectionController { | |||
|
|
|||
| const integration_key = process.env['NANGO_SLACK_INTEGRATION_KEY'] || 'slack'; | |||
| const nangoAdminUUID = NANGO_ADMIN_UUID; | |||
| const env = 'prod'; | |||
| const env = process.env['NANGO_ADMIN_PROD_ENV'] || 'prod'; | |||
There was a problem hiding this comment.
we now prefer to use the validated and type safed parsedEnvs. Example:
nango/packages/server/lib/server.ts
Line 33 in 5ea7299
There was a problem hiding this comment.
yes, and that way you can put a default value too
bodinsamuel
reviewed
Apr 2, 2025
| @@ -85,7 +87,7 @@ export class SlackService { | |||
|
|
|||
| private integrationKey = process.env['NANGO_SLACK_INTEGRATION_KEY'] || 'slack'; | |||
| private nangoAdminUUID = process.env['NANGO_ADMIN_UUID']; | |||
| private env = 'prod'; | |||
| private env = process.env['NANGO_ADMIN_PROD_ENV'] || 'prod'; | |||
There was a problem hiding this comment.
nb in shared you wont be able to use parsed, but you can refactor the class to accept the env in the constructor
bodinsamuel
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment name will soon be editable, so I'm making this value editable via env var to make it clearer.
Part of NAN-2685