-
Notifications
You must be signed in to change notification settings - Fork 484
feat(logs): global search #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs): global search #3906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 1 issue across 6 files. View it in mrge.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally. worked well.
The total logs found (top right corner) is not matching the logs being showed. Showing the total amount when the search is actually filtering rows. Is that on purpose to always show the total, regardless of the search
I would also expect the search to "follow me" when opening an operation panel. If I search for something and then click on an operation that has lots of logs. I must search again to only see the specific log entries that matches what I am looking for
Not really on purpose but it's because I don't have a way to have actual accurate numbers. The only way to fix all issues regarding count and pagination would be to:
Not sure if worth it tbh
Yes good feedback, I'm planning on doing that just after this PR |
Changes
Fixes https://linear.app/nango/issue/NAN-3039/top-level-log-search
You will see some comments in the PR, but basically, the main challenge is that it's a two-step process. First, we do a regular search on operations with the filters (if any), and then we search inside the
operationIds
that were found.Doing post-filtering instead of pre-filtering saves a lot of headaches for pagination and security, but it's not perfect.
Since the pagination is working (we have a valid cursor) but the limit might be incorrect (we asked for 20 and got less) the UI will ask for more due to the infinite scroll.
To prevent excessive HTTP calls, I have added a manual mode. As soon as you type, we stop the live refresh and disable infinite scroll. It will still try to load as much as it can when we possibly, but the initial load is always manual.
I'm actually surprised the PR is that small, hopefully it's not bringing too much bugs 🙏🏻
Screen.Recording.2025-04-24.at.15.52.06.mov