-
Notifications
You must be signed in to change notification settings - Fork 484
feat(integrations): add suport for redtail crm sandbox #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): add suport for redtail crm sandbox #3918
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
16627964 | Triggered | Username Password | e0d79b3 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
16627965 | Triggered | Generic Password | e0d79b3 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@TBonnin and @bodinsamuel another complex use case for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
token_url: https://review.crm.redtailtechnology.com/api/public/v1/authentication | ||
token_request_method: GET | ||
token_headers: | ||
authorization: Basic ${base64(${credentials.apiKey}:${credentials.username}:${credentials.password})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make more sense to split the description of the token headers into properties describing how it is being formed? At this pace we are going to create how own language and compiler just to describe and generate it.
for example:
token_headers:
header: authorization
schema: basic
token: ${credentials.apiKey}:${credentials.username}:${credentials.password}
encoding: base64
...
const expected = Buffer.from('XYZ-987:abc.def.ghi').toString('base64'); | ||
expect(output).toBe(`Authorization: ${expected}`); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding test. very needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am worried the interpolate function is gonna become too complicated at some point but otherwise thank you for doing this 👍
Describe the problem and your solution
providers.yaml
forTWO_STEP
auth mode, enabling constructs likeBasic ${base64(${credentials.apiKey}:${credentials.username}:${credentials.password})}
when building proxy headers and generating token requests.