Skip to content

feat(integrations): add suport for redtail crm sandbox #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Apr 16, 2025

Describe the problem and your solution

  • Add support for redtail crm sandbox
  • Add support for Base64-encoded values in providers.yaml for TWO_STEP auth mode, enabling constructs like
    Basic ${base64(${credentials.apiKey}:${credentials.username}:${credentials.password})} when building proxy headers and generating token requests.

Copy link

gitguardian bot commented Apr 16, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
16627964 Triggered Username Password e0d79b3 packages/shared/lib/utils/utils.unit.test.ts View secret
16627965 Triggered Generic Password e0d79b3 packages/shared/lib/utils/utils.unit.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@hassan254-prog
Copy link
Contributor Author

@TBonnin and @bodinsamuel another complex use case for TWO_STEP 🥳

@hassan254-prog hassan254-prog requested a review from a team April 16, 2025 20:19
@hassan254-prog hassan254-prog self-assigned this Apr 16, 2025
Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

token_url: https://review.crm.redtailtechnology.com/api/public/v1/authentication
token_request_method: GET
token_headers:
authorization: Basic ${base64(${credentials.apiKey}:${credentials.username}:${credentials.password})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make more sense to split the description of the token headers into properties describing how it is being formed? At this pace we are going to create how own language and compiler just to describe and generate it.
for example:

token_headers:
    header: authorization
    schema: basic
    token: ${credentials.apiKey}:${credentials.username}:${credentials.password}
    encoding: base64
...

const expected = Buffer.from('XYZ-987:abc.def.ghi').toString('base64');
expect(output).toBe(`Authorization: ${expected}`);
});
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding test. very needed

Copy link
Collaborator

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am worried the interpolate function is gonna become too complicated at some point but otherwise thank you for doing this 👍

@khaliqgant khaliqgant merged commit 55c86f9 into master Apr 21, 2025
15 checks passed
@khaliqgant khaliqgant deleted the wari/platform-changes-for-two-step-to-accommodate-redtail-crm branch April 21, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants