feat: event tracking v2 #3922
feat: event tracking v2 #3922
Conversation
| @@ -434,7 +435,7 @@ class SyncController { | |||
| try { | |||
| const { account, environment } = res.locals; | |||
|
|
|||
| const { schedule_id, command, nango_connection_id, sync_id, sync_name, sync_variant, provider, delete_records } = req.body; | |||
There was a problem hiding this comment.
can we stop passing those params in
There was a problem hiding this comment.
good point, I'll change that when migrating the endpoint
| @@ -0,0 +1,79 @@ | |||
| import { PostHog } from 'posthog-node'; | |||
There was a problem hiding this comment.
I am not a huge fan of the naming eventTracking. Soon we are going to have billing events and I am sure more sort of events in the future.
I am also not super clear of the value of PostHog. @bastienbeurier How is it being used and what does PostHog provides that we cannot have without it?
There was a problem hiding this comment.
I am not a huge fan of the naming eventTracking. Soon we are going to have billing events and I am sure more sort of events in the future.
What would you propose? Analytics was also incorrect, maybe internalEventTracking? Billing events will be called billing events, so I'm not shocked.
I am also not super clear of the value of PostHog. @bastienbeurier How is it being used and what does PostHog provides that we cannot have without it?
I'll let Bastien complete, imo those are product events; with it we have dashboards, insights, Slack alerts, trends, etc. that allow us to have a better sense of what's happening for some critical part of the product. We could not achieve the same with DD because we are missing dimensions and/or sampling, and simply not made for that.
By removing most events it's clear that it's less useful I agree
There was a problem hiding this comment.
I think it's a common argument from engs that DD can replace product analytics. Initially, it's somewhat true. But rapidly product analytics are used for a different set of events and surfacing (e.g. with Slack notifications).
There was a problem hiding this comment.
got it. productEvent, productTracking or something similar then.
There was a problem hiding this comment.
let's go for productTracking
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16627964 | Triggered | Username Password | df95f50 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
| 16627965 | Triggered | Generic Password | df95f50 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Changes
Fixes https://linear.app/nango/issue/NAN-3073/posthog-cleanup
Not useful right now