-
Notifications
You must be signed in to change notification settings - Fork 484
fix(cli): correctly resolve file with fake extension #3924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): correctly resolve file with fake extension #3924
Conversation
@@ -170,26 +170,33 @@ function compileImportedFile({ | |||
|
|||
for (const importedFile of importedFiles) { | |||
const importedFilePath = path.resolve(path.dirname(filePath), importedFile); | |||
const importedFilePathWithoutExtension = path.join(path.dirname(importedFilePath), path.basename(importedFilePath, path.extname(importedFilePath))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow where the bug is. path.basename('a/b/c/schema.zod.ts', path.extname('ts')))
should give a/b/c/schema.zod
no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because extension-less imports are valid in Typescript, so when you autocomplete, it often imports this schema.zod
and since we are less smart, we think .zod is the extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
16627964 | Triggered | Username Password | c870289 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
16627965 | Triggered | Generic Password | c870289 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Changes
Fixes https://linear.app/nango/issue/NAN-3090/cli-issue-when-detecting-lib
It was buggy when importing stuff like
schema.zod
. It was resolved toschema.ts
instead ofschema.zod.ts
.