feat: billing with Lago #3927
feat: billing with Lago #3927
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16627964 | Triggered | Username Password | 2866989 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
| 16627965 | Triggered | Generic Password | 2866989 | packages/shared/lib/utils/utils.unit.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Tested the query plan
After |
kaposke
left a comment
kaposke
left a comment
There was a problem hiding this comment.
Can I get an invite to lago?
TBonnin
left a comment
TBonnin
left a comment
There was a problem hiding this comment.
made a few tiny comments. lgtm otherwise
| report(e); | ||
| return Err(e); | ||
| } | ||
| } |
There was a problem hiding this comment.
I would retry certain errors here like network ones for instance? wdyt?
| const month = referenceDate.getUTCMonth() + 1; // js months are 0-based | ||
|
|
||
| const res = await db.readOnly | ||
| const q = db.readOnly |
There was a problem hiding this comment.
we can await the query directly. I think it is a leftover of some early-on debugging
There was a problem hiding this comment.
I don't really mind having it, sometimes its handy but yeah let's change
I cannot approved my own PR @bodinsamuel so feel free to merge once you have addressed the comments |
Changes
Send usage events to Lago
I kept the original implementation from Thomas that allows multiple clients, which can be handy if we ever want to do some integration tests.
Only send metrics for paying accounts
Lago does not reject the events, but we just we to start small
🧪 Tests