Skip to content

Conversation

@hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Oct 31, 2025

Describe the problem and your solution

  • Add support for sap s/4hana untested.

Declare SAP S/4HANA compatibility & refresh docs/assets (no runtime code)

This PR updates provider metadata, documentation and static assets to advertise existing sap-odata-basic and sap-odata-oauth2-cc connectors as SAP S/4HANA-compatible. No TypeScript/Go runtime logic, build pipeline or API surface is modified. The work is limited to YAML flags, Markdown/MDX docs and replacement of several template-logo SVGs.

Key Changes

• Added sapS4Hana: true (and related branding fields) in packages/providers/providers.yaml for sap-odata-basic and sap-odata-oauth2-cc
• Regenerated/edited docs under docs/integrations/** and docs/snippets/generated/** to reference S/4HANA, fix typos, and rebuild search index (docs/docs.json)
• Replaced/removed 20+ legacy SVGs; added updated connector logos including S/4HANA variants
• Minor grammar fix commit (grammar) to docs

Affected Areas

packages/providers/providers.yaml
docs/integrations/** and docs/snippets/generated/**
packages/webapp/public/images/template-logos/*.svg


This summary was automatically generated by @propel-code-bot

@hassan254-prog hassan254-prog force-pushed the wari/add-support-for-sap-odata branch from 9d758a0 to bf7115c Compare November 12, 2025 15:51
@hassan254-prog hassan254-prog marked this pull request as ready for review November 12, 2025 16:16
@hassan254-prog hassan254-prog requested review from a team and khaliqgant November 12, 2025 16:22
Copy link
Collaborator

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos. lgtm otherwise

type: string
title: API Server
description: The API base URL of the SAP S/4HANA cloud API service you want to connect to
pattern: '^[A-Za-z0-9.-]+(?::\d+(?:/[-A-Za-z0-9.]*)*)?$'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure about this pattern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants