-
Notifications
You must be signed in to change notification settings - Fork 593
feat(integrations): add support for sap s/4hana #4943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hassan254-prog
wants to merge
2
commits into
master
Choose a base branch
from
wari/add-support-for-sap-odata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+513
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d758a0 to
bf7115c
Compare
TBonnin
reviewed
Nov 13, 2025
Collaborator
TBonnin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some typos. lgtm otherwise
| type: string | ||
| title: API Server | ||
| description: The API base URL of the SAP S/4HANA cloud API service you want to connect to | ||
| pattern: '^[A-Za-z0-9.-]+(?::\d+(?:/[-A-Za-z0-9.]*)*)?$' |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure about this pattern?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem and your solution
Declare SAP S/4HANA compatibility & refresh docs/assets (no runtime code)
This PR updates provider metadata, documentation and static assets to advertise existing
sap-odata-basicandsap-odata-oauth2-ccconnectors as SAP S/4HANA-compatible. No TypeScript/Go runtime logic, build pipeline or API surface is modified. The work is limited to YAML flags, Markdown/MDX docs and replacement of several template-logo SVGs.Key Changes
• Added
sapS4Hana: true(and related branding fields) inpackages/providers/providers.yamlforsap-odata-basicandsap-odata-oauth2-cc• Regenerated/edited docs under
docs/integrations/**anddocs/snippets/generated/**to reference S/4HANA, fix typos, and rebuild search index (docs/docs.json)• Replaced/removed 20+ legacy SVGs; added updated connector logos including S/4HANA variants
• Minor grammar fix commit (
grammar) to docsAffected Areas
•
packages/providers/providers.yaml•
docs/integrations/**anddocs/snippets/generated/**•
packages/webapp/public/images/template-logos/*.svgThis summary was automatically generated by @propel-code-bot