fix: remove always null this.win.modal.window check in auth flows. #5025
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ej-sanmartin
changed the title
ej-sanmartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4964
Logical bug which can cause auth to error when an auth window is actually opened. Stems from a lingering window option that is
nulland confirmed to benullby issue author.#4964
Pretty safe to remove since that seems to be the intention from 32b771e
Remove redundant null check in auth modal polling loop
Eliminates a condition that always evaluated to false (
this.win.modal.windowis consistentlynull) in the interval that monitors the popup authorization window. The new logic now only checks!this.win.modal.closed, preventing the flow from aborting when a real modal is open.Key Changes
• Deleted
if (this.win.modal.window && !this.win.modal.closed)• Added simplified guard
if (!this.win.modal.closed)Affected Areas
•
packages/frontend/lib/index.ts–auth()polling loop that detects popup closureThis summary was automatically generated by @propel-code-bot