-
Notifications
You must be signed in to change notification settings - Fork 593
feat(integrations): add Zendesk Sell provider #5039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(integrations): add Zendesk Sell provider #5039
Conversation
- Add OAuth2 provider configuration for Zendesk Sell API - Configure authorization and token endpoints for api.getbase.com - Add comprehensive documentation with quickstart guide - Include API reference for deals, contacts, and organizations - Add SVG logo for Zendesk Sell integration - Update docs index to include zendesk-sell documentation This enables users to connect their Zendesk Sell CRM accounts and access sales data including deals, contacts, and more through the standardized Nango OAuth flow.
Replace generic icon with official Zendesk triangular logo design in template-logos directory. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fine-tune logo dimensions for better visual consistency in integration template grid. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Increase logo paths to utilize full 62x62 canvas for better visibility and visual impact in integration template grid. - Scale main triangle from 20px to 50px width - Add viewBox for proper scaling behavior - Maintain triangular Zendesk brand design - Center logo with appropriate margins 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
hassan254-prog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution 🙏 , small comments inline otherwise looks good.
- Add token_request_auth_method: basic for better OAuth2 token exchange - Remove unnecessary verification section and headers from proxy config - Restructure documentation following tiktok-personal.mdx template - Remove Python SDK examples (Nango doesn't have Python SDK) - Add proper OAuth setup instructions and useful links section - Improve user experience with streamlined quickstart flow 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
@hassan254-prog thank you for the review! 🙌 Looking forward to another review! |
hassan254-prog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments otherwise looks good to merge.
- Clarify that Nango doesn't provide test OAuth app for Zendesk Sell - Update documentation links to use current Zendesk developer portal URLs - Remove outdated API gotchas (pagination and field filtering details) - Maintain rate limit information as it's still accurate 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Thank you @hassan254-prog, I have resolved these issues in commit - f0ff7b2 Looking forward to a (hopefully) final review! |
This enables users to connect their Zendesk Sell CRM accounts and access sales data including deals, contacts, and more through the standard Nango OAuth2 flow.
Add First-Class Zendesk Sell OAuth2 Provider with Docs & Branding
This PR adds native support for Zendesk Sell (formerly Base CRM) to Nango’s integration catalogue. It introduces a full OAuth2 provider configuration, thorough end-user documentation, and brand assets to surface the new provider in the UI. Changes are purely additive and confined to provider metadata, docs, and static assets—no runtime code paths are touched.
Key Changes
• Added Zendesk Sell OAuth2 definition to packages/providers/providers.yaml
• Created new integration guide docs/integrations/all/zendesk-sell.mdx with autogenerated snippets
• Updated docs index/sidebar to surface the new page
• Added Zendesk Sell SVG logo to webapp/public/images/template-logos
• No changes to runtime logic or existing APIs
Affected Areas
• packages/providers/providers.yaml
• Documentation site (docs/, docs/docs.json, sidebar)
• Static asset directory (webapp/public/images/template-logos)
This summary was automatically generated by @propel-code-bot