Skip to content

Conversation

@ej-sanmartin
Copy link

@ej-sanmartin ej-sanmartin commented Nov 20, 2025

Describe

#4750 didn't surface watermark disabling and enabling in frontend, where it was previously just checking if user has a plan. Now, frontend has similar checks with backend https://github.com/NangoHQ/nango/blob/master/packages/shared/lib/services/connect-ui-settings.service.ts#L94-L100 when it comes to enabling / disabling Nango watermark in settings.


Issue

Fixes #4915


Testing

  • Ran locally in docker
  • Vid Demo of Self Hosted Enabling Watermark Removal
Screen.Recording.2025-11-19.at.7.04.09.PM.mov

Expose hosting flags & unify watermark-disable logic

Adds isHosted and isEnterprise flags to the env JS payload and propagates them through shared types. Front-end settings page now mirrors the back-end rule for deciding whether the Connect UI watermark can be disabled, fixing the inability to remove the watermark in self-hosted deployments. Tooltip copy is updated to provide context-specific guidance.

Key Changes

• Updated packages/server/lib/controllers/v1/getEnvJs.ts to append isHosted and isEnterprise to window._env and include them in the features object returned to the browser
• Extended WindowEnv interface in packages/types/lib/web/env.ts with isHosted and isEnterprise booleans
• Refactored packages/webapp/src/pages/Environment/Settings/ConnectUISettings/index.tsx to compute canDisableWatermark using globalEnv flags and environment plan; switch disabled state and tooltip message now conditional on the new logic

Affected Areas

getEnvJs controller (env JS generation)
WindowEnv shared type
• Connect UI settings React component


This summary was automatically generated by @propel-code-bot

@ej-sanmartin ej-sanmartin changed the title Fix: nango watermark can't be turned off in self hosted fix: nango watermark can't be turned off in self hosted Nov 20, 2025
…gs/index.tsx

Co-authored-by: propel-code-bot[bot] <203372662+propel-code-bot[bot]@users.noreply.github.com>
Copy link
Contributor

@kaposke kaposke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing :)

@ej-sanmartin
Copy link
Author

Ran eslint to fix linting errors.

@kaposke kaposke enabled auto-merge November 24, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't disable watermark on self-hosted v0.69.5

2 participants