-
Notifications
You must be signed in to change notification settings - Fork 612
fix(providers): allow for generation of SAML assertions #5216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🤖 My Senior Dev — Analysis Complete👤 For @hassan254-prog📁 Expert in View your contributor analytics → 📊 32 files reviewed • 2 high risk 🚨 High Risk:
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
abf717d to
5b9e9c4
Compare
5b9e9c4 to
218f9b2
Compare
218f9b2 to
b80033e
Compare
Describe the problem and your solution
This PR adds a shared helper that builds and optionally signs SAML assertions from provider templates, introduces new metadata hooks for assertion options across two-step providers like SAP SuccessFactors, updates connection flows to gather those options automatically, and refreshes the SAP SuccessFactors documentation to match the streamlined experience.
Key Changes
• Added
packages/shared/lib/auth/samlAssertion.tswith XML construction, signing (xml-crypto/xmldom), interpolation handlers, and agenerateAssertionAPI for two-step providers.• Extended configuration parsing (
parseAssertionOptionParamsFromTemplate) and connection service logic to assemble credentials, interpolate assertion templates, and inject generated assertions before token exchange.• Updated
SAP SuccessFactorsprovider definition (packages/providers/providers.yaml) to supply assertion templates/options, and surfaced the new fields inConnect UI/CreateLegacyforms with validation.• Restructured SAP SuccessFactors docs into
api-integrations/hierarchy, reflecting automated assertion generation and revised credential steps; added corresponding navigation updates.Affected Areas
• packages/shared/lib/auth
• packages/shared/lib/services/connection.service.ts
• packages/connect-ui/src/views/Go.tsx
• packages/types/lib/providers/provider.ts
• packages/providers/providers.yaml
• docs/api-integrations/sap-success-factors*
This summary was automatically generated by @propel-code-bot