Skip to content

Conversation

@hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Jan 9, 2026

Describe the problem and your solution

  • Allow generation of SAML assertions without requiring users to create their own. This is particularly useful for integrations such as SAP SuccessFactors.

This PR adds a shared helper that builds and optionally signs SAML assertions from provider templates, introduces new metadata hooks for assertion options across two-step providers like SAP SuccessFactors, updates connection flows to gather those options automatically, and refreshes the SAP SuccessFactors documentation to match the streamlined experience.

Key Changes

• Added packages/shared/lib/auth/samlAssertion.ts with XML construction, signing (xml-crypto/xmldom), interpolation handlers, and a generateAssertion API for two-step providers.
• Extended configuration parsing (parseAssertionOptionParamsFromTemplate) and connection service logic to assemble credentials, interpolate assertion templates, and inject generated assertions before token exchange.
• Updated SAP SuccessFactors provider definition (packages/providers/providers.yaml) to supply assertion templates/options, and surfaced the new fields in Connect UI/CreateLegacy forms with validation.
• Restructured SAP SuccessFactors docs into api-integrations/ hierarchy, reflecting automated assertion generation and revised credential steps; added corresponding navigation updates.

Affected Areas

• packages/shared/lib/auth
• packages/shared/lib/services/connection.service.ts
• packages/connect-ui/src/views/Go.tsx
• packages/types/lib/providers/provider.ts
• packages/providers/providers.yaml
• docs/api-integrations/sap-success-factors*


This summary was automatically generated by @propel-code-bot

@hassan254-prog hassan254-prog self-assigned this Jan 9, 2026
@my-senior-dev-pr-review
Copy link

my-senior-dev-pr-review bot commented Jan 9, 2026

🤖 My Senior Dev — Analysis Complete

👤 For @hassan254-prog

📁 Expert in docs (180 edits) • ⚡ 17th PR this month

View your contributor analytics →


📊 32 files reviewed • 2 high risk

🚨 High Risk:

  • docs/api-integrations/sap-success-factors.mdx — Critical security concerns regarding handling sensitive credentials in documentation.

⚠️ Needs Attention:

  • docs/api-integrations/sap-success-factors.mdx — Important documentation updates that may impact user experience and safety.

🚀 Open Interactive Review →

The full interface unlocks features not available in GitHub:

  • 💬 AI Chat — Ask questions on any file, get context-aware answers
  • 🔍 Smart Hovers — See symbol definitions and usage without leaving the diff
  • 📚 Code Archeology — Understand how files evolved over time (/archeology)
  • 🎯 Learning Insights — See how this PR compares to similar changes

💬 Chat here: @my-senior-dev explain this change — or try @chaos-monkey @security-auditor @optimizer @skeptic @junior-dev

📖 View all 12 personas & slash commands

You can interact with me by mentioning @my-senior-dev in any comment:

In PR comments or on any line of code:

  • Ask questions about the code or PR
  • Request explanations of specific changes
  • Get suggestions for improvements

Slash commands:

  • /help — Show all available commands
  • /archeology — See the history and evolution of changed files
  • /profile — Performance analysis and suggestions
  • /expertise — Find who knows this code best
  • /personas — List all available AI personas

AI Personas (mention to get their perspective):

Persona Focus
@chaos-monkey 🐵 Edge cases & failure scenarios
@skeptic 🤨 Challenge assumptions
@optimizer Performance & efficiency
@security-auditor 🔒 Security vulnerabilities
@accessibility-advocate Inclusive design
@junior-dev 🌱 Simple explanations
@tech-debt-collector 💳 Code quality & shortcuts
@ux-champion 🎨 User experience
@devops-engineer 🚀 Deployment & scaling
@documentation-nazi 📚 Documentation gaps
@legacy-whisperer 🏛️ Working with existing code
@test-driven-purist Testing & TDD

For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews.

@hassan254-prog hassan254-prog requested a review from a team January 12, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants