Skip to content

Conversation

@hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Jan 13, 2026

Describe the problem and your solution

  • add support for ecu360, this is still ongoing.

Add ECU360 integration and adjust two-step credential expiry parsing

Introduces ECU360 as a new two-step provider with associated documentation, catalog entry, and logo asset. Updates ConnectionService.parseRawCredentials so two-step credentials only fall back to DEFAULT_INFINITE_EXPIRES_AT_MS after strategy-specific parsing, allowing provider-defined defaults (such as ECU360's token_expires_in_ms) to apply when no expiration field is returned.

Key Changes

• Registered ECU360 in packages/providers/providers.yaml with two-step auth metadata (token endpoint, headers, credential prompts, docs links, and a 15-minute default expiration).
• Added provider documentation pages (docs/api-integrations/ecu360.mdx, docs/api-integrations/ecu360/connect.mdx) and wired the new guide into docs/docs.json along with a corresponding logo asset packages/webapp/public/images/template-logos/ecu360.svg.
• Modified packages/shared/lib/services/connection.service.ts two-step parsing logic to leave expiration undefined until after strategy evaluation, then fall back to template-specific or infinite defaults.

Affected Areas

• packages/providers/providers.yaml
• packages/shared/lib/services/connection.service.ts
• docs/api-integrations/ecu360.mdx
• docs/api-integrations/ecu360/connect.mdx
• docs/docs.json
• packages/webapp/public/images/template-logos/ecu360.svg


This summary was automatically generated by @propel-code-bot

@hassan254-prog hassan254-prog self-assigned this Jan 13, 2026
@my-senior-dev-pr-review
Copy link

my-senior-dev-pr-review bot commented Jan 13, 2026

🤖 My Senior Dev — Analysis Complete

👤 For @hassan254-prog

📁 Expert in docs (221 edits) • ⚡ 23rd PR this month

View your contributor analytics →


📊 7 files reviewed • 1 high risk • 2 need attention

⚠️ Needs Attention:

  • docs/api-integrations/ecu360.mdx — The documentation includes critical guidance on handling sensitive API credentials, making misconfiguration a high-security risk.

🚀 Open Interactive Review →

The full interface unlocks features not available in GitHub:

  • 💬 AI Chat — Ask questions on any file, get context-aware answers
  • 🔍 Smart Hovers — See symbol definitions and usage without leaving the diff
  • 📚 Code Archeology — Understand how files evolved over time (/archeology)
  • 🎯 Learning Insights — See how this PR compares to similar changes

💬 Chat here: @my-senior-dev explain this change — or try @chaos-monkey @security-auditor @optimizer @skeptic @junior-dev

📖 View all 12 personas & slash commands

You can interact with me by mentioning @my-senior-dev in any comment:

In PR comments or on any line of code:

  • Ask questions about the code or PR
  • Request explanations of specific changes
  • Get suggestions for improvements

Slash commands:

  • /help — Show all available commands
  • /archeology — See the history and evolution of changed files
  • /profile — Performance analysis and suggestions
  • /expertise — Find who knows this code best
  • /personas — List all available AI personas

AI Personas (mention to get their perspective):

Persona Focus
@chaos-monkey 🐵 Edge cases & failure scenarios
@skeptic 🤨 Challenge assumptions
@optimizer Performance & efficiency
@security-auditor 🔒 Security vulnerabilities
@accessibility-advocate Inclusive design
@junior-dev 🌱 Simple explanations
@tech-debt-collector 💳 Code quality & shortcuts
@ux-champion 🎨 User experience
@devops-engineer 🚀 Deployment & scaling
@documentation-nazi 📚 Documentation gaps
@legacy-whisperer 🏛️ Working with existing code
@test-driven-purist Testing & TDD

For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews.

@hassan254-prog hassan254-prog added this pull request to the merge queue Jan 13, 2026
Merged via the queue into master with commit 9451588 Jan 13, 2026
24 checks passed
@hassan254-prog hassan254-prog deleted the wari/add-support-ecu360 branch January 13, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants