fix(usage): serialize addSession to prevent lost updates on concurrent writes - #1201
Open
aakashsharma7 wants to merge 1 commit into
Open
Conversation
…t writes Serialize read-modify-write calls to usage.json using an in-process Promise-chain lock and write to a temporary file before atomically renaming into place. This prevents concurrent session completions (such as simultaneous subagent runs) from overwriting each other's session usage data and lifetime totals.
aakashsharma7
requested review from
Avtrkrb,
akramcodez and
will-lamerton
as code owners
September 6, 2026 05:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
addSession()had a race when multiple sessions finished at the same time (for example parallel subagents). Each caller did a non-atomic read-modify-write onusage.json, so a later write could replace an earlier one using a stale baseline and drop usage data.Changes
Atomic writes — write to
${filePath}.${uuid}.tmp, thenfs.renameSyncso concurrent readers never see empty or truncated JSON.In-process lock— serialize read-modify-write with a Promise-chain lock (
withUsageLock), same pattern assession-manager.ts.addSessionis async — now returnsPromise<void>and runs insidewithUsageLock.Changeset + test — patch changeset, plus a concurrency regression test that fires several sessions with
Promise.all.Testing