Skip to content

fix(nc-review): stop set -e killing the step on exactly one nit #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
will-lamerton merged 1 commit into from
Sep 6, 2026
Merged

fix(nc-review): stop set -e killing the step on exactly one nit #1214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions .github/workflows/nc-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,14 +460,31 @@ jobs:
fi

CLAIMED=$(jq -r '.verdict // "(none)"' "$V")
[ "$CLAIMED" != "$VERDICT" ] && \
if [ "$CLAIMED" != "$VERDICT" ]; then
echo "::notice::model said '$CLAIMED', findings imply '$VERDICT' — using '$VERDICT'"
fi

# Human-readable tally, e.g. "1 blocking, 2 important, 2 nits".
# Plain if-blocks, not `[ ... ] && VAR=...`. Under `set -e` an
# assignment takes the exit status of its command substitution, so
#
# COUNTS="...${N_NIT} nit$([ "$N_NIT" -gt 1 ] && echo s)"
#
# killed the whole step whenever there was exactly ONE nit: the inner
# test returned 1, the substitution inherited it, and the assignment
# failed. Silently, because every echo below is redirected into
# comment.md. It survived earlier runs only because they had no nits.
COUNTS=""
[ "$N_BLOCK" -gt 0 ] && COUNTS="${N_BLOCK} blocking"
[ "$N_IMP" -gt 0 ] && COUNTS="${COUNTS:+$COUNTS, }${N_IMP} important"
[ "$N_NIT" -gt 0 ] && COUNTS="${COUNTS:+$COUNTS, }${N_NIT} nit$([ "$N_NIT" -gt 1 ] && echo s)"
if [ "$N_BLOCK" -gt 0 ]; then
COUNTS="${N_BLOCK} blocking"
fi
if [ "$N_IMP" -gt 0 ]; then
COUNTS="${COUNTS:+$COUNTS, }${N_IMP} important"
fi
if [ "$N_NIT" -gt 0 ]; then
if [ "$N_NIT" -eq 1 ]; then NITW="nit"; else NITW="nits"; fi
COUNTS="${COUNTS:+$COUNTS, }${N_NIT} ${NITW}"
fi

{
case "$VERDICT" in
Expand Down
Loading