feat(nc-review): mention the author, and track what a re-review fixed - #1217
Conversation
Two changes. Mention the PR author, so the review reaches them instead of waiting to be noticed. Bots are skipped — dependabot and github-actions cannot read a review and an @-mention on every dependency bump is noise. Detection uses the API's is_bot rather than matching a "[bot]" suffix, which would miss accounts that do not follow the convention. Feed the previous verdict back in on /re-review. Without it the agent re-derives every finding from scratch and re-files ones the author has already fixed, which is worse than not re-reviewing at all: it tells someone their work did not land. The most recent nc-review comment is now included in the context, with instructions to sort each prior point into resolved / not resolved / cannot tell, and a new `addressed` array in the schema. Fixed points are rendered as an explicit "Addressed since the last review" block rather than silently dropped. Absence is ambiguous — from the author's side it reads as the bot forgetting rather than the work landing. The rubric also says plainly that re-raising a fixed point is the fastest way to make people stop reading the reviews, and that a fix can introduce a new problem which is a new finding like any other. Verified by extracting the real Post review step and running it against three cases: a re-review with three addressed items and one remaining finding, a bot author (no mention emitted), and a first review with no `addressed` field (no empty block). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZY52ePXLjwG9TaQgq2cHT
No changeset foundThis PR does not add a changeset, so it will not appear in the changelog or trigger a release. If the change is user-facing, add one: pnpm changesetPick a bump (patch / minor / major) and write the changelog entry in our usual voice ("Added X... Thanks to @you. Closes #123."), then commit the generated If this PR is docs-only or a chore that needs no release note, you can ignore this — or run |
nc-review: nothing to raiseThe change adds an author mention to nc-review comments (skipping bots via the API's 🔴 blocking · 🟠 a reviewer would ask for a change · ⚪ optional Automated code review — correctness, security, design, tests, plus duplicates and scope. A human still decides; this is not a substitute for review and is not exhaustive. The required status checks separately cover lint, formatting, types, unused dependencies, the test suite and the build. This bot never merges. Maintainers can rerun with |
Two changes.
1. Mention the PR author
So the review reaches them rather than waiting to be noticed.
Bots are skipped. dependabot and github-actions cannot read a review, and an
@-mention on every dependency bump is pure noise. Detection uses the API'sis_botflag rather than matching a[bot]suffix, which would miss accounts that do not follow the convention.2. Track what a
/re-reviewactually fixedPreviously a re-review re-derived every finding from scratch, with no memory of what it had already said. That means re-filing points the author has already fixed — which is worse than not re-reviewing at all, because it tells someone their work did not land.
The most recent nc-review comment is now included in the context, with instructions to sort each prior point into resolved / not resolved / cannot tell, plus a new
addressedarray in the schema.Fixed points render explicitly rather than being silently dropped — absence is ambiguous, and from the author's side reads as the bot forgetting rather than the work landing:
The rubric also now says plainly that re-raising a fixed point is the fastest way to make people stop reading, and that a fix can introduce a new problem which is a new finding like any other.
Verified
Extracted the real
Post reviewstep and ran it against three cases:addressedfield → no empty block