Skip to content

refactor(data): require isEval on every helper that writes to the dataset #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
addyCooks wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(data): require isEval on every helper that writes to the dataset #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d104fc2
refactor(data): require isEval on every helper that writes to the dat…
addyCooks Sep 2, 2026
aa03a34
test(data): cover the importer skip paths; keep chat's /keep call to …
addyCooks Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/commands/chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,8 @@ export function ChatCommand({options}: Props) {
return;
}
try {
appendToTrainingData({contextMessage: systemMessage, ...exchange});
const kept = {contextMessage: systemMessage, ...exchange};
appendToTrainingData(kept, false);
appendTurn({
role: 'info',
content: `Kept last exchange (${countExamples()} examples total).`,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/chat-helpers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ test.serial("saveTranscript output is importable by nanotune data import", (t) =
inProject("importable", () => {
mkdirSync(join(".nanotune", "data"), { recursive: true });
const path = saveTranscript(SYSTEM, HISTORY);
const result = importData(path, { role: "system", content: "ignored" });
const result = importData(path, { role: "system", content: "ignored" }, false);
t.deepEqual(result.errors, []);
t.is(result.imported, 1);
t.is(result.skipped, 0);
Expand Down
Loading
Loading