Roelofr feature/GitHub actions #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lowered phpunit min version to 8.0 to allow --prefer-lowest to work right.
…ueprint-nova-addon into roelofr-feature/github-actions
Contributor
|
I noticed some changes in the WIPs so far, you may want to consider:
I'm currently on mobile, so these are just some suggestions being shouted from a couch. |
Owner
Author
|
@roelofr yes you are right. Not sure why it is not passing on github actions but locally... maybe you can take another look and find something I missed |
roelofr
reviewed
Feb 2, 2021
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update |
Contributor
There was a problem hiding this comment.
This call doesn't actually install anything anymore, so the tests probably go boom
Owner
Author
There was a problem hiding this comment.
No, the command works fine, but the test's assertion fail
| ->ignoreDotFiles(true) | ||
| ->ignoreVCS(true); | ||
|
|
||
| return PhpCsFixer\Config::create() |
Contributor
There was a problem hiding this comment.
If memory serves me right, this is deprecated. Use new PhpCsFixer\Config instead
Owner
Author
|
@roelofr any chance you can look into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32