Skip to content

Option to constrain initial CAPEX #491

Merged
adfarth merged 20 commits intodevelopfrom
add-cost-constraint
May 6, 2025
Merged

Option to constrain initial CAPEX #491
adfarth merged 20 commits intodevelopfrom
add-cost-constraint

Conversation

@adfarth
Copy link
Copy Markdown
Collaborator

@adfarth adfarth commented Mar 19, 2025

Adds inputs: min_initial_capital_costs_before_incentives and max_initial_capital_costs_before_incentives which constrain a calculation equivalent to the result Financial.initial_capital_costs.

Note: The Financial results initial_capital_costs and initial_capital_costs_after_incentives do not currently account for the third_party_factor. I.e., they indicate the cost to the third party but not the capex from the host's perspective. See this result which shows the initial capex and lifecycle capex as different despite no replacements or incentives: https://reopt.nrel.gov/tool/results/c6164b3a-e59b-4efe-b034-0397a0429960. This is the current behavior and is persisted in this PR.

Comment thread src/constraints/cost_curve_constraints.jl Outdated
Comment thread src/constraints/cost_curve_constraints.jl Outdated
@adfarth adfarth marked this pull request as ready for review April 16, 2025 18:06
@adfarth adfarth requested a review from zolanaj April 16, 2025 18:06
Copy link
Copy Markdown
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a bunch @adfarth! I checked and ran a separate local test to confirm the function of the constraints, and I like the moving of the financial expression into a new function before the objective. I have one quick question on outside test changes and a couples opinions on TODO's in the function, but this is ready to merge as-is, once the changelog is updated!

Comment thread test/runtests.jl
Comment thread src/constraints/cost_curve_constraints.jl Outdated
Comment thread src/constraints/cost_curve_constraints.jl
Comment thread src/results/financial.jl Outdated
@zolanaj
Copy link
Copy Markdown
Collaborator

zolanaj commented May 2, 2025

@adfarth in addition to the changelog update, I added an error check for min > max capital cost input. Let me know if you have any concerns - thanks!

@adfarth adfarth merged commit 19de1d3 into develop May 6, 2025
2 checks passed
@adfarth adfarth deleted the add-cost-constraint branch May 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants