Conversation
adfarth
commented
Mar 27, 2025
adfarth
commented
Mar 27, 2025
zolanaj
approved these changes
May 2, 2025
Collaborator
There was a problem hiding this comment.
Looks good, thanks a bunch @adfarth! I checked and ran a separate local test to confirm the function of the constraints, and I like the moving of the financial expression into a new function before the objective. I have one quick question on outside test changes and a couples opinions on TODO's in the function, but this is ready to merge as-is, once the changelog is updated!
zolanaj
reviewed
May 2, 2025
Collaborator
|
@adfarth in addition to the changelog update, I added an error check for min > max capital cost input. Let me know if you have any concerns - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds inputs:
min_initial_capital_costs_before_incentivesandmax_initial_capital_costs_before_incentiveswhich constrain a calculation equivalent to the resultFinancial.initial_capital_costs.Note: The
Financialresultsinitial_capital_costsandinitial_capital_costs_after_incentivesdo not currently account for thethird_party_factor. I.e., they indicate the cost to the third party but not the capex from the host's perspective. See this result which shows the initial capex and lifecycle capex as different despite no replacements or incentives: https://reopt.nrel.gov/tool/results/c6164b3a-e59b-4efe-b034-0397a0429960. This is the current behavior and is persisted in this PR.