Conversation
|
To do: Add a test case in which we compare (a) the new degradation model; (b) the previous one that tracks E_plus and E_minus, and (c) a case in which we double the degradation of E_minus and remove E_plus from the previous model to compare the end SOH for a unit test case. |
also, reach out to Paul G. once we have tests up and running to get his buy-in. |
…ntDischargePower and
these are already tracking with dvSegmentChargePower and dvSegmentDischargePower
Fix replacement month to get this test to solve with HiGHS
| Base.@kwdef mutable struct Degradation | ||
| calendar_fade_coefficient::Real = 2.55E-03 | ||
| cycle_fade_coefficient::Real = 9.83E-05 | ||
| cycle_fade_coefficient::Vector{<:Real} = [9.83E-05] |
There was a problem hiding this comment.
@rathod-b could you add a bit more explanation of these inputs within the help text? esp. how the cycle fade fraction vector related to the cycle fade coef vector
There was a problem hiding this comment.
This might take some time, will tackle this after other changes are made.
|
@rathod-b would it be possible to add kWh capacity versions of the outputs: |
no longer relevant |
commented out test that does not work as expected on github, validated locally.
Battery residual factor is 80% + remaining healthy SOH, instead of applying the residual factor to the entire battery.
correct calculation of total residual bess SOH
|
@zolanaj I made a few final adjustments to account for recent changes to electric storage O&M costs and not to double count degradation related costs. Please take a look. |
zolanaj
left a comment
There was a problem hiding this comment.
Thanks for the heads up on this @rathod-b! I have a couple suggested edits. The only other thing not covered here is we might want to warn the user any time we zero out a value that is inappropriately entered with the degradation model, since the field names make it not obvious (unless the warning in the docs is read carefully). Let me know if you have questions - thanks!
| - `state_of_health` | ||
| - `maintenance_cost` | ||
| - `replacement_month` | ||
| - `residual_value` # only applies is maintenance_strategy = "replacement" |
There was a problem hiding this comment.
This should be "total_residual_kwh" right? Could you also add a short explanation of what it is here?
There was a problem hiding this comment.
This list should include "total_residual_kwh" as well. Added in 3c50f50
| ## segmented_cycle_degr | ||
| ### Added | ||
| - Added constraints in `src/constraints/battery_degradation.jl` to allow use of segmented cycle fade coefficients in the model. | ||
| - Added **cycle_fade_fraction** as an input for portion of BESS that is tied to each cycle fade coefficient. |
There was a problem hiding this comment.
Could you add the "total_residual_kwh" ElectricStorage output here too?
Add total_residual_kwh in code markdown.
Uh oh!
There was an error while loading. Please reload this page.