Update add-cst-reopt with develop#496
Merged
jtkadlec merged 674 commits intoadd-cst-reoptfrom May 1, 2025
Merged
Conversation
Normalize and scale load profile, refactor (mostly heating) load code
Avoid "no method matching isapprox(String,String)
HeatingLoad Refactor, Normalize-Scale Loads, Other Fixes
…ric and heating This is causing issues with common web-tool usage. A longer term fix will be pushed soon.
Hot Fix: Remove error throw with inconsistent load year between elect…
… year instead of leap day
After tax savings for simple payback
…en-source solvers Also, remove obsolete statement that HiGHS is not compatible with certain scenarios, as we've changed everything in the model to Big M to be compatible with HiGHS.
Fix Production Based Incentives
merge develop with CST feature branch
…eopt-with-develop
…eopt-with-develop
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation and configuration files to better align with current solver recommendations and usage practices, as well as to update compatibility references. Key changes include:
- Updated documentation examples to favor HiGHS as the default open‐source solver.
- Adjusted function names and headers in inputs and outputs documentation to reflect revised API naming.
- Upgraded Julia version references in CI workflows and project files.
Reviewed Changes
Copilot reviewed 122 out of 132 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/src/reopt/outputs.md | Added BAU scenario documentation for financial outputs. |
| docs/src/reopt/inputs.md | Renamed and updated headers and function calls for load inputs. |
| docs/src/reopt/examples.md | Updated examples to use HiGHS and revised file path references. |
| docs/src/index.md | Revised installation instructions and added new environment variables. |
| docs/README.md | Updated project description and usage examples. |
| CHANGELOG.md | Extended changelog with new updates and refactors. |
| docs/Project.toml | Updated Julia compatibility version. |
| .github/workflows/build_docs.yml & CI.yml | Upgraded CI workflows to use Julia 1.10. |
Files not reviewed (10)
- data/ashp/ashp_defaults.json: Language not supported
- data/load_profiles/cooling_electric_annual_kwh.json: Language not supported
- data/load_profiles/domestic_hot_water_annual_mmbtu.json: Language not supported
- data/load_profiles/space_heating_annual_mmbtu.json: Language not supported
- data/load_profiles/total_electric_annual_kwh.json: Language not supported
- docs/devdeploy.jl: Language not supported
- src/REopt.jl: Language not supported
- src/constraints/battery_degradation.jl: Language not supported
- src/constraints/electric_utility_constraints.jl: Language not supported
- src/constraints/emissions_constraints.jl: Language not supported
Comments suppressed due to low confidence (2)
docs/src/reopt/outputs.md:8
- [nitpick] The wording 'Financial outputs adders' may be unclear; consider renaming this header to something more descriptive such as 'BAU Scenario Financial Outputs' for improved clarity.
## Financial outputs adders with BAU Scenario
docs/README.md:12
- There appears to be a stray comma before
HiGHS; removing it will improve the readability of the sentence.
The REopt package has been tested with , `HiGHS`, `Cbc`, `SCIP`, `Xpress` (commercial), and `CPLEX` (commercial).
Collaborator
Author
|
@jtkadlec This should be ready for you to merge and allow all tests to pass! I made a few changes so that there's a single directory for all SAM files which may change how you're running things locally potentially. I started a small entry for the changelog - I know there are more additions than what's in there but hopefully this is a start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.