Skip to content

Fix ExistingChiller sizing issue#583

Merged
atpham88 merged 5 commits intodevelopfrom
existing-chiller-debug
Apr 6, 2026
Merged

Fix ExistingChiller sizing issue#583
atpham88 merged 5 commits intodevelopfrom
existing-chiller-debug

Conversation

@atpham88
Copy link
Copy Markdown
Collaborator

@atpham88 atpham88 commented Mar 11, 2026

Overview

This PR addresses two issues related to ExistingChiller sizing (#569 and #568):

  • ExistingChiller only applies an extra 1.25 factor on peak to chiller's size in the optimal case when no capital cost is provided. It still only applies the 1.25 factor one time (correctly) in BAU or when capital cost is provided
  • Fix: Switch to use max(dvCoolingProduction) for chiller's size instead of dvSize. I'm unclear why dvSize gives a different value than max(dvCoolingProduction) in some cases at this point but will look into this more later (issued documented: ExistingChiller's size #587).

Validation

  • Test case for a commercial building in Atlanta with both heating and cooling loads. Confirmed that chiller size only applies 1.25 factor ONE TIME across settings (without cap cost, with cap cost, in BAU, in Optimal without GHP deployment).
  • Also tested with Amanda's demo case study for a commercial building in Denver where capital cost of ExistingChiller is not provided. Confirmed chiller's size in BAU is the same as in optimal case without GHP deployment.
  • Details of results for both of these tests are here https://github.com/atpham88/existing_chiller_debug_REopt/tree/main/results.

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Docs have been added / updated if applicable
  • Any new packages have been added to the [compat] section of Project.toml
  • REopt version number is updated in Project.toml and CHANGELOG.md if merging into master (do this right before merging)
  • Tests for the changes have been added. These tests should compare against expected values that are calculated independently of running REopt. Tests should also include garbage collection (see other tests for examples).
  • Any new REopt outputs and required inputs have been added to the corresponding Django model in the REopt API

Replace this with a description of the changes (can just copy from CHANGELOG.md)

@atpham88 atpham88 requested review from Bill-Becker and adfarth March 11, 2026 21:58
Copy link
Copy Markdown
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atpham88 before merging, could you update the CHANGELOG and also create a new issue for this: "I'm unclear why dvSize gives a different value than max(dvCoolingProduction) in some cases at this point but will look into this more later."?

Copy link
Copy Markdown
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atpham88 sorry--I thought I had approved this before! Approving pending getting tests to pass (I see some are failing now)

@atpham88 atpham88 merged commit 42d9566 into develop Apr 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants