Fix override of scratch_dir#51
Merged
Merged
Conversation
The code was in some cases only writing to the system's temp filesystem. This would fail on the HPC with multiple nodes. The code needs to allow an override that forces use of the shared filesystem.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 44 44
Lines 3461 3461
=======================================
Hits 3165 3165
Misses 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lixiliu
approved these changes
Jun 27, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
* Fix override of scratch_dir The code was in some cases only writing to the system's temp filesystem. This would fail on the HPC with multiple nodes. The code needs to allow an override that forces use of the shared filesystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was in some cases only writing to the system's temp filesystem. This would fail on the HPC with multiple nodes. The code needs to allow an override that forces use of the shared filesystem.