-
Notifications
You must be signed in to change notification settings - Fork 7
Replace SQLAlchemy with ibis-framework for all database operations #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
daniel-thom
wants to merge
46
commits into
main
Choose a base branch
from
feat/replace-sqlalchemy-with-ibis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
24fa83b
Replace SQLAlchemy with ibis-framework for all database operations
daniel-thom 26393c7
Fix review issues: cleanup safety, column ordering, schema uniqueness
daniel-thom 6584bd4
Address PR comments
daniel-thom 0eede6f
Fix spark functionality
daniel-thom afd1a8f
Code cleanup
daniel-thom 0e71e9a
Code cleanup
daniel-thom cc44ef3
Code cleanup
daniel-thom 177ca7e
Code cleanup
daniel-thom a6f710b
Fix CI
daniel-thom 184317b
Address PR comments
daniel-thom 874ebd0
Add test coverage
daniel-thom 7ca977b
Fix dispose in owned session
daniel-thom 650a506
Fix tests
daniel-thom b4f2d6a
Spark fixes
daniel-thom bfc2684
Fix CI failures
daniel-thom ed8c2a2
Increase test coverage
daniel-thom 472d7bc
Address PR review feedback
daniel-thom cdcef84
Update lab name
daniel-thom 5ec2b2e
Spark fixes
daniel-thom 827d849
Restore DuckDB native fetch_df path and limit cache invalidation to DDL
daniel-thom c2e8d06
Use transactions
daniel-thom 63ea56a
Move per-backend I/O logic from functions.py into IbisBackend
daniel-thom 04cffe0
Return ibis.Table from Store.read_query/read_table
daniel-thom 652a7a2
Remove table cache and collapse pure-delegation backend methods
daniel-thom 4cd5c4c
Fix mypy strict-mode errors in ibis backends
daniel-thom beaabc7
Use ibis to_parquet in backend write_parquet implementations
daniel-thom aaa08c3
Use Ibis natives in Store and drop chronify.duckdb helpers
daniel-thom 42db94a
Apply schema-driven type casts to Store.read_table
daniel-thom fc3a69f
Delegate backend insert/view creation to Ibis natives
daniel-thom d43760f
Defer ibis.Table materialization through the write path
daniel-thom 96bf822
Drop intermediate ymdh table even when apply_mapping fails
daniel-thom d176f59
Fix Spark test cleanup and period lookup
daniel-thom 85423a1
Fix mypy error
daniel-thom cb1fe37
Restore docstrings on Store ingest and time-config methods
daniel-thom 4eedfa2
Replace raw SQL with ibis expressions in checker and CSV reader
daniel-thom d7a4ce8
Fix UTC handling for Spark
daniel-thom 280c950
Update docs
daniel-thom c6c7a6a
Refactor code
daniel-thom f7a52b8
Fix SQLite DDL atomicity and simplify transaction handling
daniel-thom 17ca716
Make parquet promotion crash-safe
daniel-thom 511cf7b
Make post-promotion backup cleanup non-fatal
daniel-thom 6af444c
Harden post-failure cleanup and document Spark rollback limits
daniel-thom 17bccf6
Restore _in_transaction type annotation for mypy
daniel-thom b03b41a
Fix Spark partitioned Parquet writes
daniel-thom e6755fb
Suppress pyarrow.compute attr-defined error for assume_timezone
daniel-thom 0a8df8f
Address Copilot review: 'None' tz sentinel and cursor cleanup
daniel-thom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.