Skip to content

Add Linear Generator Model#240

Open
dzalkind wants to merge 50 commits intoNatLabRockies:developfrom
dzalkind:f/linear_generator
Open

Add Linear Generator Model#240
dzalkind wants to merge 50 commits intoNatLabRockies:developfrom
dzalkind:f/linear_generator

Conversation

@dzalkind
Copy link
Copy Markdown
Collaborator

@dzalkind dzalkind commented Mar 27, 2026

This PR adds a model for a linear generator, characterized by it's relatively flat efficiency curve and fast ramp rates and cooldown times.

A few parameters of this model are still uncertain, and we should reach out for clarification on them, including

  • Efficiency: the curve is flat, a single value is provided by the Mainspring data sheet.
  • Hot/warm/cold startup times: these are my best guesses, but should also be verified
  • Time to reach a warm, cold off state: these are currently hard coded in ThermalComponentBase. I suggest we parameterize these and add the following states (OFF_HOT, OFF_WARM, OFF_COLD), but should discuss.

I suggest we proceed with estimate and update the parameters in a future PR.

I added a DEFAULTS dict in LinearGenerator to simplify the checking and testing of these values. No need to do this for past components, but it could be helpful for others going forward.

In the example, I'm modeling a single linear generator to demonstrate it's features. Typically, it will be used in an array, but that is a separate feature/example and we can work on more control approaches in Hycon. I'm open to feedback on the example.

I'm not sure if we want to specifically call out Mainspring, but that is where a lot of our information has come from.

TODO:

  • Merge Multiunit thermal plants #224 when ready
  • Finalize parameters
  • (discuss) and implement OFF_* states
  • Revert nrel-pysam stuff I was tinkering with or fix it

dzalkind and others added 30 commits March 4, 2026 14:37
This reverts commit 71f3c90, reversing
changes made to bb51e82.
@dzalkind dzalkind marked this pull request as ready for review April 27, 2026 18:13
@dzalkind dzalkind requested a review from Copilot April 27, 2026 19:18
@genevievestarke genevievestarke requested review from genevievestarke, jfrederik-nrel, misi9170 and paulf81 and removed request for Copilot April 27, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants