Skip to content

feat: add custom label overrides and tooltips for vocabulary properties#2014

Open
jdfranel wants to merge 4 commits intoNatLibFi:mainfrom
jdfranel:feat/vocabulary-property-label-override
Open

feat: add custom label overrides and tooltips for vocabulary properties#2014
jdfranel wants to merge 4 commits intoNatLibFi:mainfrom
jdfranel:feat/vocabulary-property-label-override

Conversation

@jdfranel
Copy link
Copy Markdown
Contributor

Reasons for creating this PR

Adding properties to a vocabulary other than those translated in the source code results in a raw property key in the vocabulary page. If I need idot:prefix term in my vocabulary it is not translated.

Link to relevant issue(s), if any

None

Description of the changes in this PR

I changed the vocabulary template so property label overrides defined in the skosmos.ttl vocabulary definition is applied to its properties.

Known problems or uncertainties in this PR

None

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@jdfranel jdfranel marked this pull request as ready for review April 22, 2026 10:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.04%. Comparing base (2f195e3) to head (940ff9f).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/controller/WebController.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2014      +/-   ##
============================================
- Coverage     70.42%   70.04%   -0.39%     
  Complexity     1703     1703              
============================================
  Files            34       34              
  Lines          4436     4486      +50     
============================================
+ Hits           3124     3142      +18     
- Misses         1312     1344      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant