Ekir 306 handle licenses of title appearing in feed multiple times#144
Merged
natlibfi-kaisa merged 3 commits intomainfrom Mar 25, 2025
Conversation
NatLibFi-JoonaKupe
approved these changes
Mar 24, 2025
natlibfi-psams
approved these changes
Mar 25, 2025
natlibfi-kaisa
deleted the
EKIR-306-Handle-licenses-of-title-appearing-in-feed-multiple-times
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was noticed that a work entry can appear several times in a feed. This PR ensures that licenses that really have been removed from the feed are set as unavailable and any existing ones with relevant details.
Motivation and Context
This fixes the the problem noticed after implementing https://jira.it.helsinki.fi/browse/EKIRJASTO-218.
How Has This Been Tested?
Unit tests. Locally can be tested with two titles in our test feed which appears twice: One of them with a license each time, and the other has two licenses of which one is expired and the other is not. After importing the feed, you can run license_report to check their statuses: only the expired one should be
unavailable.No actually missing licenses are in our test environment, though.
Checklist