Merged
Conversation
Links field turned out to be missing when getting a request for ODL loan notifications. Make it optional for now even though it should be a required field.
natlibfi-burger
approved these changes
Jun 9, 2025
natlibfi-psams
pushed a commit
that referenced
this pull request
Jun 17, 2025
Links field turned out to be missing when getting a request for ODL loan notifications. Make it optional for now even though it should be a required field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make Links an optional field in Loan Status Document.
Motivation and Context
Missing Links field caused a validation error when getting ODL loan notification requests. It should be a MUST field according to https://readium.org/lcp-specs/releases/lsd/latest.html#25-links but make it optional for now.
How Has This Been Tested?
Can't really be tested locally, only in our test environment.
Checklist