Ekir 427 push notification texts to finnish#164
Merged
natlibfi-kaisa merged 6 commits intomainfrom Jun 12, 2025
Merged
Conversation
natlibfi-burger
approved these changes
Jun 12, 2025
natlibfi-psams
pushed a commit
that referenced
this pull request
Jun 17, 2025
* EKIR-427 Reserved hold ends EOD * EKIR-427 Use Finnish notification text for now * EKIR-427 Change loan notification days * EKIR-427 Update tests * EKIR-427 Handle missing hold end just in case * EKIR-427 Fix odl test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardcode notification texts into Finnish for now. Loan notifications should be sent 3 and 1 days before expiry.
Motivation and Context
To enable the quick release of push notifications, using Finnish texts is the fastest way until we figure out how to translate the notifications.
How Has This Been Tested?
Tests.
Checklist