Conversation
aatuny
requested changes
Nov 20, 2025
Contributor
aatuny
left a comment
aatuny
left a comment
There was a problem hiding this comment.
Good work and code quality is on par with current repo code quality.
Asking for few improvements:
- check msg/result of year filter tests as I observed some inconsistency
- use example.com TLD in tests
- do not allow ISBN from URN (at least yet, until we have confirmation from metadata expert on this subject)
- add JSDoc style comments at least for the ISBN-filtering function as reverse parameter might be difficult to interpret
aatuny
approved these changes
Nov 24, 2025
aatuny
added a commit
that referenced
this pull request
Dec 17, 2025
* Refactor filters (#293) * Update actions * Update dependencies * 3.1.0-alpha.1 --------- Co-authored-by: Joni Ollila <53558796+natlibfi-jonollil@users.noreply.github.com> Co-authored-by: aatuny <27770287+aatuny@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.