Migrate CICD to GH actions - #62
Open
juhoinkinen wants to merge 13 commits into
Open
Conversation
Member
Author
|
The rust-build job still fails. In the fork I had unintentionally updated also the Cargo.lock at repo root, which is why the CI passed there: https://github.com/NatLibFi/omikuji2/blob/6b242f1787332ec7f2485019db022c141b04d936/Cargo.lock |
There was a problem hiding this comment.
Pull request overview
Migrates the project’s CI/CD from Azure Pipelines to GitHub Actions, including building/testing Rust + Python artifacts and publishing Python distributions to PyPI.
Changes:
- Add a GitHub Actions CI workflow to run Rust checks/tests and build/test Python sdist and wheels across Linux (manylinux), macOS, and Windows.
- Add a GitHub Actions release workflow intended to publish built artifacts to PyPI after successful CI runs on tags.
- Update packaging/build logic for macOS to produce a universal2 (x86_64 + arm64) native library, and update README badge; remove Azure Pipelines configs.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updates native build steps, including macOS universal2 dylib creation. |
| README.md | Replaces Azure Pipelines badge with GitHub Actions CI badge. |
| .github/workflows/ci.yaml | Introduces GitHub Actions CI matrix for Rust + Python builds/tests and artifact uploads. |
| .github/workflows/release.yaml | Introduces GitHub Actions workflow intended to publish artifacts to PyPI after CI completion. |
| .ci/azure-setup-rust.yml | Removes Azure Pipelines Rust setup template. |
| .ci/azure-python-build.yml | Removes Azure Pipelines Python build template. |
| .ci/azure-pipelines.yml | Removes Azure Pipelines pipeline definition. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
It seems that Cargo has been creating the directory, but this ensures it exists Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
They are supported, in the sense that CI passes
head_branch is set to the tag name Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleaned-up version of the PR to the previous fork: NatLibFi#4