[v.0.4] Add default initializer via $default method#172
Open
soulofmischief wants to merge 1 commit into
Open
Conversation
0281b66 to
865e975
Compare
865e975 to
666e9c0
Compare
Author
|
Should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a symbol that can be used to key a default initializer function in a component. It throws if the initializer isn't a function.
The API is such:
Not sure if you wanted direct support for a default initializer, but this seems like a non-intrusive way to do it. Anything I should change/add if you want to merge?
I know you mentioned in #105 that you wanted to avoid invoking GC or creating unnecessary objects, but this approach is entirely opt-in, doesn't modify the API, and only introduces one conditional check for the $default property.
It's up to the user to avoid invoking GC with the default method, but it's no different than the user just setting these values manually every time after adding a component, or using a prefab. We could also include a stronger warning in the docs. The
Default()wrapper also gives the user a way to avoid double initialization.