Camera centric

CHANGELOG.md

@@ -1,12 +1,28 @@
 ## main
 
 ### ✨ Features and improvements
+- ⚠️ Changed `geometry-type` to identify "Multi-" features ([#4877](https://github.com/maplibre/maplibre-gl-js/pull/4877))
+- Add support for pitch > 90 degrees ([#4717](https://github.com/maplibre/maplibre-gl-js/issues/4717))
 - _...Add new stuff here..._
 
 ### 🐞 Bug fixes
+- ⚠️ Fix order of normalizeSpriteURL and transformRequest in loadSprite ([#3897](https://github.com/maplibre/maplibre-gl-js/issues/3897))
+- ⚠️ Remove unminified prod build ([#4906](https://github.com/maplibre/maplibre-gl-js/pull/4906))
+- Fix issue where raster tile source won't fetch updates following request error ([#4890](https://github.com/maplibre/maplibre-gl-js/pull/4890))
+- _...Add new stuff here..._
+
+## v5.0.0-pre.3
+
+### ✨ Features and improvements
+
+- Add support for camera roll angle ([#4717](https://github.com/maplibre/maplibre-gl-js/issues/4717))
+
+### 🐞 Bug fixes
+
 - Fix text not being hidden behind the globe when overlap mode was set to `always` ([#4802](https://github.com/maplibre/maplibre-gl-js/issues/4802))
+- Fix 3D models in custom layers not being properly occluded by the globe ([#4817](https://github.com/maplibre/maplibre-gl-js/issues/4817))
 - Fix a single white frame being displayed when the map internally transitions from mercator to globe projection ([#4816](https://github.com/maplibre/maplibre-gl-js/issues/4816))
-- _...Add new stuff here..._
+- Fix loading of RTL plugin version 0.3.0 ([#4860](https://github.com/maplibre/maplibre-gl-js/pull/4860))
 
 ## 5.0.0-pre.2
 

build/generate-doc-images.ts

@@ -34,7 +34,7 @@ async function createImage(exampleName) {
         const waitTime = (exampleName.includes('3d-model') || exampleName.includes('globe')) ? 5000 : 1500;
         console.log(`waiting for ${waitTime} ms`);
         await new Promise(resolve => setTimeout(resolve, waitTime));
-    } catch (err) {
+    } catch {
         // map.loaded() does not evaluate to true within 3 seconds, it's probably an animated example.
         // In this case we take the screenshot immediately.
         console.log(`Timed out waiting for map load on ${exampleName}.`);

build/generate-struct-arrays.ts

@@ -407,7 +407,7 @@ export class ${structArrayClass} extends ${structArrayLayoutClass} {`);
         output.push(
             `    /**
      * Return the ${structTypeClass} at the given location in the array.
-     * @param index The index of the element.
+     * @param index - The index of the element.
      */
     get(index: number): ${structTypeClass} {
         return new ${structTypeClass}(this, index);

build/rollup_plugins.ts

@@ -16,7 +16,7 @@ export const nodeResolve = resolve({
     preferBuiltins: false
 });
 
-export const plugins = (production: boolean, minified: boolean): Plugin[] => [
+export const plugins = (production: boolean): Plugin[] => [
     json(),
     // https://github.com/zaach/jison/issues/351
     replace({
@@ -31,9 +31,8 @@ export const plugins = (production: boolean, minified: boolean): Plugin[] => [
         sourceMap: true,
         functions: ['PerformanceUtils.*']
     }),
-    minified && terser({
+    terser({
         compress: {
-            // eslint-disable-next-line camelcase
             pure_getters: true,
             passes: 3
         },

developer-guides/center-point.md

@@ -0,0 +1,32 @@
+# How Camera position is calculated
+
+This guide describes how camera position is calculated from the center point, zoom, and camera rotation.
+The `Transform` variables `center`, `elevation`, `zoom`, `pitch`, `bearing`, and `fov` control the location of the camera indirectly.
+
+ `elevation` sets the height of the "center point" above sea level. In the typical use case (`centerClampedToGround = true`), the library modifies `elevation` in an attempt to keep the center point always on the terrain (or 0 MSL if no terrain is enabled). When `centerClampedToGround = false`, the user provides the elevation of the center point.
+
+`zoom` sets the distance from the center point to the camera (in conjunction with `fovInRadians`, which is currently hardcoded).
+
+Together, `zoom`,  `elevation`, and `pitch` set the altitude of the camera:
+
+See `MercatorTransform::getCameraAltitude()`:
+```typescript
+    getCameraAltitude(): number {
+        const altitude = Math.cos(this.pitchInRadians) * this._cameraToCenterDistance / this._helper._pixelPerMeter;
+        return altitude + this.elevation;
+    }
+```
+
+![image](assets/center-point_nominal.png)
+
+To allow pitch > 90, the "center point" must be placed off of the ground. This will allow the camera to stay above the ground when it pitches above 90. This requires setting `centerClampedToGround = false`.
+
+![image](assets/center-point_high-pitch.png)
+
+The same math applies whether the center point is on terrain or not, and whether the camera is above or below the ground: 
+
+![image](assets/center-point_straight-up.png)
+![image](assets/center-point_underground.png)
+
+
+To help users position the camera, `Camera` exports the function `calculateCameraOptionsFromCameraLngLatAltRotation()`.

eslint.config.js

@@ -0,0 +1,157 @@
+import typescriptEslint from '@typescript-eslint/eslint-plugin';
+import stylisticTs from '@stylistic/eslint-plugin-ts'
+import tsdoc from 'eslint-plugin-tsdoc';
+import jest from 'eslint-plugin-jest';
+import globals from 'globals';
+import tsParser from '@typescript-eslint/parser';
+import react from 'eslint-plugin-react';
+import html from 'eslint-plugin-html';
+
+export default [
+    {
+        ignores: ['build/*.js', 'staging/**', 'coverage/**', 'node_modules/**', 'docs/**', 'dist/**']
+    },
+    {
+        ignores: ['test/bench/**'],
+        files: ['**/*.ts', '**/*.js'],
+        plugins: {
+            '@typescript-eslint': typescriptEslint,
+            '@stylistic': stylisticTs,
+            tsdoc,
+            jest,
+        },
+
+        linterOptions: {
+            reportUnusedDisableDirectives: true,
+        },
+
+        languageOptions: {
+            globals: {
+                ...Object.fromEntries(Object.entries(globals.browser).map(([key]) => [key, 'off'])),
+                performance: true,
+            },
+
+            parser: tsParser,
+            ecmaVersion: 5,
+            sourceType: 'module',
+
+            parserOptions: {
+                createDefaultProgram: true,
+            },
+        },
+
+        rules: {
+            'no-dupe-class-members': 'off',
+            '@typescript-eslint/no-dupe-class-members': ['error'],
+
+            '@typescript-eslint/no-unused-vars': ['warn', {
+                argsIgnorePattern: '^_',
+            }],
+
+            '@stylistic/member-delimiter-style': ['error'],
+            'no-useless-constructor': 'off',
+            '@typescript-eslint/no-useless-constructor': ['error'],
+            'no-undef': 'off',
+            'no-use-before-define': 'off',
+            'no-duplicate-imports': 'off',
+            'implicit-arrow-linebreak': 'off',
+            'arrow-parens': 'off',
+            'arrow-body-style': 'off',
+            'no-confusing-arrow': 'off',
+            'no-control-regex': 'off',
+            'no-invalid-this': 'off',
+            'no-buffer-constructor': 'off',
+            'array-bracket-spacing': 'error',
+            'consistent-return': 'off',
+            'global-require': 'off',
+            'key-spacing': 'error',
+            'no-eq-null': 'off',
+            'no-lonely-if': 'off',
+            'no-new': 'off',
+
+            'no-restricted-properties': [2, {
+                object: 'Object',
+                property: 'assign',
+            }],
+
+            'no-unused-vars': 'off',
+            'no-warning-comments': 'error',
+            'object-curly-spacing': ['error', 'never'],
+            'prefer-arrow-callback': 'error',
+
+            'prefer-const': ['error', {
+                destructuring: 'all',
+            }],
+
+            'prefer-template': 'error',
+            'prefer-spread': 'off',
+            quotes: 'off',
+            '@stylistic/quotes': ['error', 'single'],
+            'no-redeclare': 'off',
+            '@typescript-eslint/no-redeclare': ['error'],
+            'space-before-function-paren': 'off',
+            'template-curly-spacing': 'error',
+            'no-useless-escape': 'off',
+            indent: 'off',
+            '@stylistic/indent': ['error'],
+
+            'no-multiple-empty-lines': ['error', {
+                max: 1,
+            }],
+
+            'tsdoc/syntax': 'warn',
+            'jest/no-commented-out-tests': 'error',
+            'jest/no-disabled-tests': 'warn',
+            'jest/no-focused-tests': 'error',
+            'jest/prefer-to-contain': 'warn',
+            'jest/prefer-to-have-length': 'warn',
+            'jest/valid-expect': 'error',
+            'jest/prefer-to-be': 'warn',
+            'jest/no-alias-methods': 'warn',
+            'jest/no-interpolation-in-snapshots': 'warn',
+
+            'jest/no-large-snapshots': ['warn', {
+                maxSize: 50,
+                inlineMaxSize: 20,
+            }],
+
+            'jest/no-deprecated-functions': 'warn',
+        },
+    },
+    {
+        files: ['**/*.html'],
+        plugins: {
+            html
+        },
+        rules: {
+            'no-restricted-properties': 'off',
+            'new-cap': 'off',
+            '@typescript-eslint/no-unused-vars': 'off'
+        }
+    },
+    {
+        files: ['test/bench/**/*.jsx', 'test/bench/**/*.js', 'test/bench/**/*.ts'],
+        plugins: {
+            react
+        },
+        rules: {
+            'react/jsx-uses-vars': [2],
+            'no-restricted-properties': 'off'
+        },
+        languageOptions: {
+            globals: {
+                ...Object.fromEntries(Object.entries(globals.browser).map(([key]) => [key, 'off'])),
+                performance: true,
+            },
+
+            parser: tsParser,
+            ecmaVersion: 5,
+            sourceType: 'module',
+
+            parserOptions: {
+                createDefaultProgram: true,
+            },
+        },
+    },
+
+];