Split the query string off a native route URI before resolving it - #401
Open
simonhamp wants to merge 1 commit into
Open
Split the query string off a native route URI before resolving it#401simonhamp wants to merge 1 commit into
simonhamp wants to merge 1 commit into
Conversation
NativeRouter::resolve() matched the whole URI against patterns registered as paths, so a deep link carrying a query string could not find its screen. The parsed query now rides back on the resolution and callers merge it into the component's navigation data, reaching the screen as $this->data(). Fixes #290. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011YQ2eoCskiHcorgsqaZ7zf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeRouter::resolve() matched the whole URI against patterns registered as paths, so a deep link with a query string could not find its screen. The parsed query now reaches the screen as
$this->data().Fixes #290.