Drop phpstan-deprecation-rules - #411
Draft
shanerbaner82 wants to merge 1 commit into
Draft
Conversation
The package reports every call to anything marked @deprecated, which fails the build for internal code that is tagged for a future reader rather than for consumers — a back-compat shim's own call sites are the case that prompted this. Deprecating an internal helper should not mean choosing between a red build and dropping the note. Nothing else here relies on it: the analysis runs at level 0, and these rules came in through phpstan/extension-installer rather than phpstan.neon. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015NQcYw62aFuTwy8RrZT6wJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package flags every call to anything marked
@deprecated, which means tagging an internal helper fails the build on the call sites that are supposed to exist. It came up on #410: a back-compat shim carried a@deprecatednote aimed at whoever deletes it later, and PHPStan reported all five uses from the two compilers that legitimately construct it. The choice was a red build or dropping the note, and neither is right for code with no consumers outside core.Nothing else depends on it. The analysis runs at level 0 and these rules arrived through
phpstan/extension-installerrather than anything inphpstan.neon, so removing the requirement is the whole change.