fix: native methods expecting a NSError arg will now throw a JS exception if the error arg is not passed #311
+78
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we discussed on Discord.
If a native obj-c method like this
openReturningError(error?)is called without the error argument it will throw a JS Error if an error is "triggered"The JS Error named "NSError" will have a
localizedDescriptionas the message and code,domain,nativeException properties.@edusperoni dont hesitate to comment on the actual code. I am no v8 expert and i was helped by AI.
I tested the code and it works.