-
-
Notifications
You must be signed in to change notification settings - Fork 103
Bradley (proxy support + other features) #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…teClient function, updated supporting files config.ts updated configuration schema to handle new definitions. Updated fileService.ts to handle new proxy options, and other related files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx a lot !!
Can you update to the last documentation structure (pull develop) and adjust you merge request to accommodate it ?
Also if you want I can add you as an official contributor to this repo as it seems that you're working on pretty cool new features and you could be a great addition to this team 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the file structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some nice updates.
Can you jus try to not change the file structure and not change the github links please ?
Beside that, I like :
- the "table of content".
- the "Features" sections (Current + Added).
- the "Contribution" section.
- the "License" section.
- the footer with "License, Version, Issues, Forks and Stars".
The roadmap could be a great addition but for now We can put it to the side and rethink about it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thebestbradley What about adding you as an official contributor on this repo ? This way we could put our efforts together 🙂 Of course you can keep your fork and continue to work on it if you want and/or prefer.
No description provided.