Skip to content

Conversation

@acolwell
Copy link
Collaborator

@acolwell acolwell commented May 4, 2025

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

  • Create natron-build-deps-common package to hold all common deps.
  • Modified natron-build-deps-qt5 to use new natron-build-deps-common package.
  • Added natron-build-deps-qt6 package for Qt6 builds.

Have you tested your changes (if applicable)? If so, how?

Yes. Build pacman repo action builds packages successfully and the Windows installer build action also builds Qt5 installers with these refactored packages successfully.

@acolwell acolwell force-pushed the refactor_natron_build_deps_packages branch from d44e68f to 1f06583 Compare May 4, 2025 01:55
Copy link
Member

@YakoYakoYokuYoku YakoYakoYokuYoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #1044. I cannot approve this based on what it was said there.

@acolwell
Copy link
Collaborator Author

acolwell commented May 5, 2025

Same as #1044. I cannot approve this based on what it was said there.

This is completely unnecessary and just stonewalling. Please stop.

Refactoring this is necessary so that the windows packages can be used by both branches. In this particular case it is a cross-cutting concern for both branches since the Qt5 code would need to use the Qt5 package and the Qt6 code would use the Qt6 one. Both of them depend on a common package. Not doing this means I'll have to manage different sets of packages for each branch. That is unnecessary work and will make maintaining CI for both branches more annoying.

- Create natron-build-deps-common package to hold all common deps.
- Modified natron-build-deps-qt5 to use new natron-build-deps-common
  package.
- Added natron-build-deps-qt6 package for Qt6 builds.
@acolwell acolwell force-pushed the refactor_natron_build_deps_packages branch from 1f06583 to bebdba7 Compare May 5, 2025 14:05
@acolwell acolwell dismissed YakoYakoYokuYoku’s stale review May 7, 2025 13:25

Have approval from rodlie and devernay.

@acolwell acolwell merged commit abcec7f into NatronGitHub:RB-2.6 May 7, 2025
4 checks passed
@acolwell
Copy link
Collaborator Author

acolwell commented May 7, 2025

Thanks for the review.

@acolwell acolwell deleted the refactor_natron_build_deps_packages branch May 7, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants