Skip to content

Conversation

@acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Recently mingw changed the signature for wstat() in a way that started causing compiler errors. This change simply removes a previous fix related to wstat() added last year. It appears to no longer be needed and its removal fixes the current build error.

Have you tested your changes (if applicable)? If so, how?

Yes. Verified build package repo action builds successfully

Recently mingw changed the signature for wstat() in a way that
started causing compiler errors. This change simply removes a
previous fix related to wstat() added last year. It appears to
no longer be needed and its removal fixes the current build error.
@acolwell
Copy link
Collaborator Author

I'm going to commit this despite the Windows Test CI failing because that failure appears to be an unrelated clang issue that I haven't quite tracked down yet. Landing this will at least allow my pacman repo nightly to start working again.

@acolwell acolwell merged commit c3d8358 into NatronGitHub:RB-2.6 May 24, 2025
3 of 4 checks passed
@acolwell acolwell deleted the fix_imagemagick_package branch May 24, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants