Skip to content

Conversation

@acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Shiboken2 and Shiboken6 rely on llvm-config to find the location of clang and its include directory. Recently the clang package had llvm-config split out into a llvm-tools package. This change adds llvm-tools to Natron's build deps packages so that llvm-config will get installed when those packages are installed.

Have you tested your changes (if applicable)? If so, how?

Yes. Verified CI Tests , Windows Installer, and build pacman repo GitHub actions all successfully build again.

Shiboken2 and Shiboken6 rely on llvm-config to find the location of clang and its
include directory. Recently the clang package had llvm-config split out into a
llvm-tools package. This change adds llvm-tools to Natron's build deps packages
so that llvm-config will get installed when those packages are installed.
@acolwell acolwell merged commit 5688775 into NatronGitHub:RB-2.6 May 25, 2025
4 checks passed
@acolwell acolwell deleted the fix_clang_errors_on_windows_build branch May 25, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants