Skip to content

Conversation

@acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fixes the script so that it always outputs paths with forward slashes even on Windows when using a Windows native Python build instead of the msys2/cygwin one. Forward slash paths are needed because this is the form qmake/cmake uses internally and is what is expected when they call this build script.

Have you tested your changes (if applicable)? If so, how?

Yes. Verified cmake build still works via Tests action. Verified qmake build still works via Build installer action. Manually verified a cmake build inside VS Code works with both msys2 python and Windows native python.

Futher details of this pull request

While technically this isn't needed given our current build scripts, it is helpful to actually have the script output the intended path separators independent of which python is being used. The use of os.path.normpath() introduces the python build dependent behavior as part of its normalization logic on Windows. The PurePath code simply allows us to reliably convert the separators back to the posix style after normalization.

Fixes the script so that it always outputs paths with forward
slashes even on Windows when using a Windows native Python build
instead of the msys2/cygwin one. Forward slash paths are needed
because this is the form qmake/cmake uses internally and is what
is expected when they call this build script.
@acolwell acolwell merged commit f605382 into NatronGitHub:RB-2.6 Jun 11, 2025
3 checks passed
@acolwell acolwell deleted the fix_sourcelist_paths branch June 11, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants