Skip to content

Conversation

@acolwell
Copy link
Collaborator

@acolwell acolwell commented Jul 2, 2025

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fixes Windows specific code in CMake files by using the proper platform variable for Windows.

This is a slightly modified version of @cedricp changes proposed in #1040.

Have you tested your changes (if applicable)? If so, how?

Built locally and verified Windows specific files were properly included on Windows build.

Fixes Windows specific code in CMake files by using
the proper platform variable for Windows.

This is a slightly modified version of @cedricp changes
proposed in NatronGitHub#1040.
@acolwell acolwell requested a review from rodlie July 2, 2025 16:06
@acolwell acolwell merged commit 5d74bca into NatronGitHub:RB-2.6 Jul 2, 2025
3 checks passed
@acolwell acolwell deleted the fix_win_cmake_var branch July 2, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants