Non-datastore resources #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rarely, resource data may get deleted from the datastore, but the resource itself is still accessible as a raw file. This fix covers that eventuality, and also adds a resource breakdown for missing data (where possible) on the landing page. This does rely on datastore_active being set properly, mostly for speed reasons. Closes: #66
This should be a rare occurrence, but in case a resource has been removed from the datastore, this prevents errors in any v0 query DOIs (and also still provides links).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the landing pages for DOIs that query resources that were previously in the datastore but have since been removed and exist only as "raw" files.
This should be a very small minority of cases, but is worth covering just in case.