feat: kde globalmenu protocol#46
Draft
CertainLach wants to merge 4 commits into
Draft
Conversation
Contributor
Author
|
Have missed that, but seems like upstream also had PR for this, but it is much more incomplete: |
Contributor
Author
|
Just to link all the changes I did for myself, on my desktop it works as a noctalia shell plugin, and this plugin needs this quickshell change: quickshell-mirror/quickshell#484 Noctalia-shell plugin: https://github.com/CertainLach/noctalia-global-menu |
Contributor
Author
|
Converting to draft, as it is breaking menus unconditionally, until user has something that can make use of appmenu registrar to display the menus |
cd0d6f4 to
c924845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes themselves work, but I can't provide a quick thing to test them, because my desktop for this feature consists of multiple ugly hacks, I have only tested it in quickshell+noctalia, plasmashell doesn't start in kiri for me, not sure if it knows about the window ids.
For some programs, e.g dolphin, the warning
Is displayed, because this call is being performed right after the surface creation (before the window is even stored in unmapped), and I have no idea how to properly handle things like that in smithay.
I also feel like it should be not stored in Unmapped/Mapped, but associated directly with surface id, but again, I'm not that familiar with smithay
The globalmenu should also be disableable, both on wayland and on dbus level, because presence of wayland interface disables default menus in kde apps, and on dbus level in xwayland apps...
For xwayland I have no idea for now about where the data should be stored, and how can we map from window id provided by xwayland apps to the window id that is being provided to e.g quickshell