Skip to content

fix: don't wait for inclusion when finalizing transfers on evm #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiseln merged 2 commits into from
Apr 3, 2026
Merged

fix: don't wait for inclusion when finalizing transfers on evm #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f982669
fix: don't wait for transaction inclusion when finalizing transfers o…
kiseln Apr 3, 2026
eaebda2
chore: bump versions
kiseln Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bridge-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "bridge-cli"
version = "0.3.44"
version = "0.3.45"
edition = "2021"
repository = "https://github.com/Near-One/bridge-sdk-rs"
rust-version = "1.88.0"
Expand Down
5 changes: 1 addition & 4 deletions bridge-cli/src/omni_connector_command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,7 @@ async fn fetch_indexer_fees(
.await
.map_err(|e| format!("Failed to fetch transfer fee: {e}"))?;

let transferred_fee = fee
.transferred_token_fee
.ok_or("Missing transferred_token_fee in response")?
.0;
let transferred_fee = fee.transferred_token_fee.map(|v| v.0).unwrap_or_default();

Ok((
transferred_fee,
Expand Down
2 changes: 1 addition & 1 deletion bridge-sdk/bridge-clients/evm-bridge-client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "evm-bridge-client"
version = "0.3.4"
version = "0.3.5"
edition = "2021"
rust-version = "1.88.0"

Expand Down
14 changes: 8 additions & 6 deletions bridge-sdk/bridge-clients/evm-bridge-client/src/evm_bridge_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,13 @@ impl EvmBridgeClient {
Some(FIN_TRANSFER_GAS),
);

let receipt = call_builder.send().await?.get_receipt().await?;
let pending = call_builder.send().await?;
let tx_hash = *pending.tx_hash();
tracing::info!(
tx_hash = format!("{:?}", receipt.transaction_hash),
tx_hash = format!("{tx_hash:?}"),
"Sent finalize transfer transaction"
);
Ok(receipt.transaction_hash)
Ok(tx_hash)
}
ChainKind::Eth | ChainKind::Base | ChainKind::Arb | ChainKind::Bnb | ChainKind::Pol => {
let bridge_deposit = OmniBridge::TransferMessagePayloadWithoutMessage {
Expand All @@ -363,12 +364,13 @@ impl EvmBridgeClient {
Some(FIN_TRANSFER_GAS),
);

let receipt = call_builder.send().await?.get_receipt().await?;
let pending = call_builder.send().await?;
let tx_hash = *pending.tx_hash();
tracing::info!(
tx_hash = format!("{:?}", receipt.transaction_hash),
tx_hash = format!("{tx_hash:?}"),
"Sent finalize transfer transaction"
);
Ok(receipt.transaction_hash)
Ok(tx_hash)
}
ChainKind::Near
| ChainKind::Sol
Expand Down
2 changes: 1 addition & 1 deletion bridge-sdk/connectors/omni-connector/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "omni-connector"
version = "0.3.8"
version = "0.3.9"
edition = "2021"
rust-version = "1.88.0"

Expand Down
Loading