Open
Conversation
Contributor
Author
|
@sept-en this PR doesn't solve issue
as the trader whitelisting functionality doesn't exist in solidity contract :) |
karim-en
requested changes
Jun 8, 2023
Co-authored-by: Karim <karim@aurora.dev>
sept-en
suggested changes
Jun 9, 2023
olga24912
requested changes
Jun 9, 2023
Co-authored-by: Olga Kunyavskaya <olga.kunyavskaya@aurora.dev>
olga24912
requested changes
Jun 13, 2023
| "deploy:all": "npx hardhat run scripts/deployment/deploy_testnet_bridge_with_test_tokens.js --network", | ||
| "deploy:test-tokens": "npm run compile-all && npx hardhat run scripts/deployment/deploy-test-tokens.js --network", | ||
| "deploy:bridge": "npm run compile-all && npx hardhat run scripts/deployment/deploy-bridge.js --network ", | ||
| "deploy:verify:bridge": "npm run compile-all && npx hardhat run scripts/EthErc20FastBridge/deploy_and_verify_bridge.js --network", |
Contributor
There was a problem hiding this comment.
Doesn't work for me:
olga@olga-ThinkPad-P14s-Gen-2a:~/Aurora/spectre-bridge-protocol/eth$ yarn run deploy:verify:bridge -- goerli
yarn run v1.22.19
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
$ npm run compile-all && npx hardhat run scripts/EthErc20FastBridge/deploy_and_verify_bridge.js --network goerli
> project-name@1.0.0 compile-all
> npx hardhat compile --force
[
{
version: '0.8.11',
settings: {
optimizer: [Object],
metadata: [Object],
outputSelection: [Object]
}
}
]
Compiled 25 Solidity files successfully
[
{
version: '0.8.11',
settings: {
optimizer: [Object],
metadata: [Object],
outputSelection: [Object]
}
}
]
Verifing Contract
Sleeping before verification...
0x5FB5a3EED9a8C1F4a49005EeE0930F79C2f1d669
Verifying implementation: 0xdEeDfE06F6331ff22FfB9BC5647CB5cDddB7f309
[
{
version: '0.8.11',
settings: {
optimizer: [Object],
metadata: [Object],
outputSelection: [Object]
}
}
]
Nothing to compile
ProviderError: HttpProviderError
at HttpProvider.request (/home/olga/Aurora/spectre-bridge-protocol/eth/node_modules/hardhat/src/internal/core/providers/http.ts:78:19)
at LocalAccountsProvider.request (/home/olga/Aurora/spectre-bridge-protocol/eth/node_modules/hardhat/src/internal/core/providers/accounts.ts:181:36)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at EthersProviderWrapper.send (/home/olga/Aurora/spectre-bridge-protocol/eth/node_modules/@nomiclabs/hardhat-ethers/src/internal/ethers-provider-wrapper.ts:13:20)
Successfully submitted source code for contract
contracts/EthErc20FastBridge.sol:EthErc20FastBridge at 0xdEeDfE06F6331ff22FfB9BC5647CB5cDddB7f309
for verification on the block explorer. Waiting for verification result...
Successfully verified contract EthErc20FastBridge on Etherscan.
https://goerli.etherscan.io/address/0xdEeDfE06F6331ff22FfB9BC5647CB5cDddB7f309#code
Verifying proxy: 0x5FB5a3EED9a8C1F4a49005EeE0930F79C2f1d669
Contract at 0x5FB5a3EED9a8C1F4a49005EeE0930F79C2f1d669 already verified.
Linking proxy 0x5FB5a3EED9a8C1F4a49005EeE0930F79C2f1d669 with implementation
Successfully linked proxy to implementation.
Proxy fully verified.
bridge deployed to 0x009C78a3a755EdD77242E260f37368180bBfD0f7
bridge_implementation deployed to 0xdEeDfE06F6331ff22FfB9BC5647CB5cDddB7f309
Deployment is completed.
Verifing Contract
Sleeping before verification...
0x009C78a3a755EdD77242E260f37368180bBfD0f7
Verifying implementation: 0xdEeDfE06F6331ff22FfB9BC5647CB5cDddB7f309
[
{
version: '0.8.11',
settings: {
optimizer: [Object],
metadata: [Object],
outputSelection: [Object],
libraries: {}
}
}
]
Compiled 25 Solidity files successfully
Implementation 0xdEeDfE06F6331ff22FfB9BC5647CB5cDddB7f309 already verified.
Verifying proxy: 0x009C78a3a755EdD77242E260f37368180bBfD0f7
Verification failed
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Contributor
Author
There was a problem hiding this comment.
but I see your contract is verified :(
https://goerli.etherscan.io/address/0xdEeDfE06F6331ff22FfB9BC5647CB5cDddB7f309#code
Contributor
There was a problem hiding this comment.
For me, this function works 50/50. Sometimes it works, but sometimes returns strange errors. Looks like a race condition.
Do we really need this function? We already have a command to deploy and verify. I am not sure that it is worth to debug it. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers:
deploy:allto work correctly