Conversation
06d2f37 to
6f8da1b
Compare
64450c9 to
9a08efb
Compare
Contributor
Author
|
Since now we have a dependency from |
olga24912
requested changes
Apr 11, 2025
2d2a26b to
d147f9c
Compare
Display and ToString traits are showing 'collapsed' tx hash (e.g 0x123...789) instead of full tx hash
2cbc7ea to
dd92de3
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (1)
- omni-relayer/.example-env: Language not supported
Comments suppressed due to low confidence (3)
omni-relayer/src/utils/evm.rs:237
- [nitpick] If possible, consider converting
tokenAddressto snake_case (e.g.token_address) for consistency with Rust naming conventions, unless this naming is dictated by an external schema.
tokenAddress: init_log.inner.tokenAddress,
omni-relayer/src/utils/mod.rs:2
- Removing the fee module might break functionality if there are still references to it. Please verify that no other parts of the codebase require the fee module or that appropriate updates have been made.
-pub mod fee;
.github/workflows/release.yml:62
- [nitpick] Multiple SSH keys are concatenated in this input. Ensure that only the intended key is provided or that the parsing logic correctly handles multiple keys to avoid authentication issues during deployment.
ssh-private-key: |
Contributor
Author
|
Well, looks like copilot is still not able to check if modules/files exist before writing a comment 😅 |
olga24912
approved these changes
Apr 16, 2025
e92dfe1 to
350ac25
Compare
56494de to
53550b7
Compare
karim-en
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.