Refactor ERC20-NEAR Bridge Checker to TypeScript + Zorsh#290
Merged
Refactor ERC20-NEAR Bridge Checker to TypeScript + Zorsh#290
Conversation
olga24912
requested changes
Mar 25, 2025
5fbc113 to
12be02d
Compare
olga24912
requested changes
Apr 7, 2025
| NETWORK_ETH: str({ choices: ["mainnet", "goerli", "sepolia"] }), | ||
| NETWORK_NEAR: str({ choices: ["mainnet", "testnet"] }), | ||
| BRIDGE_TOKEN_FACTORY_ACCOUNT_ID: str(), | ||
| }); |
Contributor
There was a problem hiding this comment.
We should add INFURA_API_KEY here.
/home/olga/Aurora/MainnetMigration/AuroraEthConnectorMainnetMigration/omni-bridge-migration/migration/checkERC20EthToNearTransfersFinalization/node_modules/.pnpm/envalid@8.0.0/node_modules/envalid/src/middleware.ts:49
throw new ReferenceError(
^
ReferenceError: [envalid] Env var INFURA_API_KEY was accessed but not validated. This var is set in the environment; please add an envalid validator for it.
olga24912
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the ERC20 Ethereum to NEAR Bridge transaction finalization verifier with these technical improvements:
Changes
Technical Notes
Notes
pnpm tsx index.tsinstead of the previousnode index.js