Skip to content

fix: check fee before finalizing transfer#293

Merged
karim-en merged 6 commits intomainfrom
fix/check-fee-before-finalization
Mar 11, 2025
Merged

fix: check fee before finalizing transfer#293
karim-en merged 6 commits intomainfrom
fix/check-fee-before-finalization

Conversation

@frolvanya
Copy link
Copy Markdown
Contributor

Right now everyone could sign transfer manually and since we didn't check fee after receiving SignEvent relayer would pay for any transfer without even checking if provided fee will be enough to cover cost of the transfer

@frolvanya frolvanya requested a review from karim-en March 11, 2025 22:21
@frolvanya
Copy link
Copy Markdown
Contributor Author

@race-of-sloths

@race-of-sloths
Copy link
Copy Markdown

race-of-sloths commented Mar 11, 2025

@frolvanya Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@karim-en 5

Your contribution is much appreciated with a final score of 5!
You have received 53 (50 base + 5% lifetime bonus) Sloth points for this contribution

@karim-en received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Comment thread omni-relayer/src/workers/mod.rs Outdated
@frolvanya frolvanya force-pushed the fix/check-fee-before-finalization branch from a74665b to 51a0c19 Compare March 11, 2025 23:50
@karim-en
Copy link
Copy Markdown
Collaborator

@race-of-sloths score 5

@karim-en karim-en merged commit ef63105 into main Mar 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants