Conversation
karim-en
commented
Mar 14, 2025
| eNear.finaliseNearToEthTransfer(proofData, proofBlockHeight); | ||
| } | ||
|
|
||
| function pause(uint flags) external onlyRole(DEFAULT_ADMIN_ROLE) { |
Collaborator
Author
There was a problem hiding this comment.
Let's also add pauseAll with pause manager role
Collaborator
Author
There was a problem hiding this comment.
We should unify the naming of the role between our EVM contracts.
https://github.com/Near-One/omni-bridge/blob/main/evm%2Fsrc%2Fomni-bridge%2Fcontracts%2FOmniBridge.sol#L37
kiseln
approved these changes
Mar 21, 2025
kiseln
approved these changes
Mar 24, 2025
olga24912
reviewed
Mar 25, 2025
| "Proof should be valid" | ||
| ); | ||
|
|
||
| eNear.finaliseNearToEthTransfer(proofData, proofBlockHeight); |
Contributor
There was a problem hiding this comment.
Why do we need to add a separate method to this contract? Why can't we finalize transactions directly in eNear?
Contributor
There was a problem hiding this comment.
We will replace eNear prover to the fake one to allow minting through the proxy
olga24912
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the e-near proxy contract to finalize the legacy transfers